Update dependencies and fix ESLint warnings accordingly #2433
Conversation
|
@elhigu I can restore removed code with eslint ignore and add the ToDo to review it later, if it's not an option to check it now :) |
|
@igor-savin-ht honestly I just haven't got time to read this through with thought. Smaller changes are easier to accept with confidence that they are not breaking anything :) I would prefer eslint ignore for now. |
|
@elhigu Done! |
|
There were few regex where some escape backslashes were dropped. Are you sure they work exactly the same after the changes? |
|
@elhigu ESLint was complaining about those escape backslashes being redundant, I tend to trust its judgement on that. Here is an in-depth discussion on this subject: eslint/eslint#7656 |
|
I'd rather have that global rule set so I need to verify manually e.g. with runkit that each of those regexps are working as expected after change. In this case I don't trust knex testsuite enough and I believe that eslint has them correctly fixed, but I need to be sure. |
| @@ -153,7 +153,7 @@ function convertTimezone(tz) { | |||
| if (tz === 'Z') { | |||
| return 0; | |||
| } | |||
| const m = tz.match(/([\+\-\s])(\d\d):?(\d\d)?/); | |||
| const m = tz.match(/([+\-\s])(\d\d):?(\d\d)?/); | |||
There was a problem hiding this comment.
Actually I wonder why eslint left \-escaping there.
* Update dependencies. Tweak ESLint rules to work more like they used to before * Fix indentation * Remove unnecessary escapes. * Remove unused 'usingClause' parameter. * Address CI failures. * Revert "Remove unused 'usingClause' parameter." This reverts commit aaa4d71. * eslint: add ignore with todo * dependencies: update
No description provided.